Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorect documentation for DeleteByQueryService.ProceedOnVersionConflict #1586

Closed
milesich opened this issue Feb 17, 2022 · 1 comment
Closed
Labels
Milestone

Comments

@milesich
Copy link

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.

Which version of Elastic are you using?

[x] elastic.v7 (for Elasticsearch 7.x)
[ ] elastic.v6 (for Elasticsearch 6.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v2 (for Elasticsearch 1.x)

Please describe the expected behavior

ProceedOnVersionConflict aborts the request on version conflicts.

It should say it will not abort on version conflicts.

Please describe the actual behavior

In: https://github.com/olivere/elastic/blob/release-branch.v7/delete_by_query.go#L195

ProceedOnVersionConflict aborts the request on version conflicts.

Any steps to reproduce the behavior?

@olivere olivere added the docs label Feb 17, 2022
@olivere
Copy link
Owner

olivere commented Feb 17, 2022

Yep. Thanks.

@olivere olivere added this to the 7.0.32 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants