Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile scroll issue #227

Open
jeffreykthomas opened this issue Jun 22, 2021 · 2 comments
Open

Mobile scroll issue #227

jeffreykthomas opened this issue Jun 22, 2021 · 2 comments

Comments

@jeffreykthomas
Copy link

Hello, I am having trouble being able to add any css that will allow the vsm-mob-content to scroll (when the amount fills the height of the screen). Do you have any suggestions?

@oleksiikhr
Copy link
Owner

Hello, sorry for the late reply. It's certainly bad with styles, but I'll try to help somehow:

  1. First option through normal styles and vh usage, but that's bad

You can try to solve the problem through js, like this or others.

.vsm-mob-content__wrap {
  height: calc(100vh - #{$vsm-mob-dropdown-offset} * 2);
  > .YOUR_INNER_CLASS {
    overflow-y: auto;
    overflow-x: hidden;
    height: 100%;
  }
}

If the close button should not scroll, then all styles can be added only in .vsm-mob-content__wrap class.

You can try to solve the problem through js, like this or others.

  1. There is also a dirty hack, such as take the .vsm-mob-content__wrap element and move it to the end of the</body>, and there is already a huge scope for customization without any problems.

But I don't even know if it's worth doing, it's probably better to fork and replace the implementation inside the component.

@jeffreykthomas
Copy link
Author

Okay, thank you for the insights. For now kept the menu shorter, but will look into those options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants