Merge pull request sourcegraph#356 from olafurpg/issue-319

Author: olafurpg

build.sbt

@@ -302,11 +302,12 @@ lazy val minimized8 = project
   .dependsOn(agent, plugin)
   .disablePlugins(JavaFormatterPlugin)
 
-lazy val minimized15 = project
-  .in(file("tests/minimized/.j15"))
+lazy val minimized17 = project
+  .in(file("tests/minimized/.j17"))
   .settings(
     minimizedSettings,
-    javaToolchainVersion := "15",
+    // Non-zulu release is still blocked by https://github.com/coursier/jvm-index/pull/53
+    javaToolchainVersion := "zulu:17",
     Compile / javaHome := None
   )
   .dependsOn(agent, plugin)

semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/CompilationUnitException.java

@@ -0,0 +1,12 @@
+package com.sourcegraph.semanticdb_javac;
+
+public class CompilationUnitException extends Throwable {
+  public CompilationUnitException(String compilationUnit, Throwable cause) {
+    super(compilationUnit, cause);
+  }
+
+  @Override
+  public Throwable fillInStackTrace() {
+    return this;
+  }
+}

semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/SemanticdbTaskListener.java

@@ -44,11 +44,17 @@ public void finished(TaskEvent e) {
     if (e.getKind() != TaskEvent.Kind.ANALYZE) return;
     try {
       onFinishedAnalyze(e);
-    } catch (Exception ex) {
+    } catch (Throwable ex) {
       // Catch exceptions because we don't want to stop the compilation even if this plugin has a
       // bug. We report the full stack trace because it's helpful for bug reports. Exceptions
       // should only happen in *exceptional* situations and they should be reported upstream.
-      reporter.exception(ex);
+      Throwable throwable = ex;
+      if (e.getSourceFile() != null) {
+        throwable =
+            new CompilationUnitException(
+                String.valueOf(e.getSourceFile().toUri().toString()), throwable);
+      }
+      reporter.exception(throwable);
     }
   }
 

semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/SemanticdbVisitor.java

@@ -153,6 +153,13 @@ public Void visitClass(ClassTree node, Void unused) {
       List<JCTree.JCTypeParameter> typeParameters = cls.getTypeParameters();
       int i = 0;
       for (Symbol.TypeVariableSymbol typeSym : cls.sym.getTypeParameters()) {
+        if (i >= typeParameters.size()) {
+          // Happens in testcontainers/testcontainers-java, see
+          // https://github.com/sourcegraph/lsif-java/issues/319
+          // Failed to reproduce with a minimal source file so we don't have a test case that hits
+          // this branch.
+          break;
+        }
         emitSymbolOccurrence(
             typeSym,
             typeParameters.get(i),