Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user_name_template_push_status to SAML apps. #761

Closed
Omicron7 opened this issue Nov 1, 2021 · 2 comments · Fixed by #769
Closed

Add user_name_template_push_status to SAML apps. #761

Omicron7 opened this issue Nov 1, 2021 · 2 comments · Fixed by #769
Labels
enhancement Asking for new behavior or feature

Comments

@Omicron7
Copy link
Contributor

Omicron7 commented Nov 1, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add ability to set pushStatus on okta_app_* for the Username Template object. See https://developer.okta.com/docs/reference/api/apps/#username-template-object

We have user_name_template_type set to CUSTOM for most of out apps which defaults pushStatus to DONT_PUSH. We currently need to update the Okta UI to set apps to PUSH status. It would be great to manage this in the terraform resource.

New or Affected Resource(s)

  • okta_app_saml

Potential Terraform Configuration

resource "okta_app_saml" "app" {
  label = "App"
  user_name_template_type = "CUSTOM"
  user_name_template = "user.login"
  user_name_template_push_status = "PUSH"
}

References

https://developer.okta.com/docs/reference/api/apps/#username-template-object

@Omicron7 Omicron7 added the enhancement Asking for new behavior or feature label Nov 1, 2021
@Omicron7
Copy link
Contributor Author

Omicron7 commented Nov 1, 2021

Further testing seems to suggest there is also a bug associated with this property missing. For an existing app, if pushState is set to PUSH, and we apply something else on the okta_app_saml, since the property isn't included in the request to Okta, Okta sets the pushState field back to DONT_PUSH.

@bogdanprodan-okta
Copy link
Contributor

Hi, @Omicron7! Thanks for submitting this issue! If that functionality is present in the API, I'll add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Asking for new behavior or feature
Projects
None yet
2 participants