You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment
Apologies, but Gist is blocked at work so cannot use that.
In this example, we're setting the default_app_classic_application_uri attribute which was previously empty.
Expected Behavior
When updating a brand that has an Email Domain attached, that email domain should remain attached post update.
Can this be done in the Admin UI?
Yes. And in fact, the Admin UI allows you to attach the same Email Domain to multiple brands ("Copy to another brand" option).
Can this be done in the actual API call?
Yes. However, the Update Brand API call allows you to specify the emailDomainId. On the Terraform Provider here, it's a read_only/computed attribute. This suggests that the API allows the same email domain to be attached to multiple brands.
Actual Behavior
The Email Domain gets removed from the brand and so the brand reverts to the default Okta Email sender.
Steps to Reproduce
Create a brand and Email Domain ID
Make a change to the brand via Terraform
Run Terraform Apply
Note that the email_domain_id attribute is going to be changed (known after apply)
Post apply, see via the Okta Admin Console that the Email Domain has been detached from the brand.
terraform apply
References
I've found various issues/PRs/discussions on a similar topic.
None of these appear to be addressing the issue though, and in fact seem to argue against the ability to attach the same Email Domain ID to multiple brands.
The Brands API appears to support this (as does the Admin UI, demonstrably).
Although admittedly, this does then seem to be in conflict with the email-domains API, which only provides for a single brand id against an email domain in the create operation -
The whole design between Brands and Email Domains is therefore very confusing (which I appreciate is contributing to the challenge in implementing it within the Terraform provider).
The text was updated successfully, but these errors were encountered:
Community Note
Terraform Version
v1.6.1
Affected Resource(s)
Terraform Configuration Files
Debug Output
Apologies, but Gist is blocked at work so cannot use that.
In this example, we're setting the
default_app_classic_application_uri
attribute which was previously empty.Expected Behavior
When updating a brand that has an Email Domain attached, that email domain should remain attached post update.
Can this be done in the Admin UI?
Yes. And in fact, the Admin UI allows you to attach the same Email Domain to multiple brands ("Copy to another brand" option).
Can this be done in the actual API call?
Yes. However, the Update Brand API call allows you to specify the emailDomainId. On the Terraform Provider here, it's a read_only/computed attribute. This suggests that the API allows the same email domain to be attached to multiple brands.
Actual Behavior
The Email Domain gets removed from the brand and so the brand reverts to the default Okta Email sender.
Steps to Reproduce
Create a brand and Email Domain ID
Make a change to the brand via Terraform
Run Terraform Apply
Note that the email_domain_id attribute is going to be changed (known after apply)
Post apply, see via the Okta Admin Console that the Email Domain has been detached from the brand.
terraform apply
References
I've found various issues/PRs/discussions on a similar topic.
okta_brand
'semail_domain_id
is an attribute, not an argument #1831None of these appear to be addressing the issue though, and in fact seem to argue against the ability to attach the same Email Domain ID to multiple brands.
The Brands API appears to support this (as does the Admin UI, demonstrably).
Although admittedly, this does then seem to be in conflict with the email-domains API, which only provides for a single brand id against an email domain in the create operation -
Whilst the update operation doesn't even have a brand_id property -
The whole design between Brands and Email Domains is therefore very confusing (which I appreciate is contributing to the challenge in implementing it within the Terraform provider).
The text was updated successfully, but these errors were encountered: