Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

validateClaims() called without type from verify() #75

Closed
lex0r opened this issue Mar 3, 2021 · 3 comments · Fixed by #76
Closed

validateClaims() called without type from verify() #75

lex0r opened this issue Mar 3, 2021 · 3 comments · Fixed by #76

Comments

@lex0r
Copy link

lex0r commented Mar 3, 2021

Hi, after reviewing the latest master I came to a conclusion that this call is not a valid one (the 2nd argument is missing):

$this->validateClaims($decoded->getClaims());

Is verify() now irrelevant?

@bryanapellanes-okta
Copy link

@lex0r,
Thanks for reaching out! I'll bring your question to the attention of our Php developers to get you an answer.

Thanks for using Okta!

@bretterer
Copy link
Contributor

@lex0r, you are absolutely correct. I will push a fix in a few minutes.

You are correct though, I would suggest using verifyIdToken and verifyAccessToken instead of verify()

@bretterer
Copy link
Contributor

Thank you again for bringing this to our attention. verify now works as it did before, and validates as an accessToken. Sorry for the introduced bug, we will look at how we can make sure this doesn't happen in the future.

You can download the newest version 1.1.1 from packagist

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants