Skip to content

Commit f74aab3

Browse files
committed
MTA-2096: Incompleted tests are displayed as passed in test results list
- Fixed fatal on old tests
1 parent 49d5a51 commit f74aab3

File tree

2 files changed

+28
-28
lines changed

2 files changed

+28
-28
lines changed

Magento/Mtf/TestCase/Functional.php

+28
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,13 @@ abstract class Functional extends \PHPUnit_Framework_TestCase
121121
*/
122122
protected $outputBufferingActive = false;
123123

124+
/**
125+
* Is test incomplete.
126+
*
127+
* @var bool
128+
*/
129+
protected $isIncomplete = false;
130+
124131
/**
125132
* @var array
126133
*/
@@ -686,4 +693,25 @@ protected function verifyMockObjects()
686693
$mockObject->__phpunit_verify();
687694
}
688695
}
696+
697+
/**
698+
* Get incomplete status of test.
699+
*
700+
* @return bool
701+
*/
702+
public function getIsIncomplete()
703+
{
704+
return $this->isIncomplete;
705+
}
706+
707+
/**
708+
* Set incomplete status of test.
709+
*
710+
* @param bool $status
711+
* @return void
712+
*/
713+
public function setIsIncomplete($status)
714+
{
715+
$this->isIncomplete = $status;
716+
}
689717
}

Magento/Mtf/TestCase/Injectable.php

-28
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,6 @@ abstract class Injectable extends Functional
6868
*/
6969
protected $currentVariation = [];
7070

71-
/**
72-
* Is test incomplete.
73-
*
74-
* @var bool
75-
*/
76-
protected $isIncomplete = false;
77-
7871
/**
7972
* Constructs a test case with the given name
8073
*
@@ -308,25 +301,4 @@ protected function prepareConstraintObject(array $constraints)
308301
['codeConstraints' => array_keys($constraintsArray)]
309302
);
310303
}
311-
312-
/**
313-
* Get incomplete status of test.
314-
*
315-
* @return bool
316-
*/
317-
public function getIsIncomplete()
318-
{
319-
return $this->isIncomplete;
320-
}
321-
322-
/**
323-
* Set incomplete status of test.
324-
*
325-
* @param bool $status
326-
* @return void
327-
*/
328-
public function setIsIncomplete($status)
329-
{
330-
$this->isIncomplete = $status;
331-
}
332304
}

0 commit comments

Comments
 (0)