Skip to content

Commit e1261c7

Browse files
steffen-maiergregkh
authored andcommitted
scsi: zfcp: Report port fc_security as unknown early during remote cable pull
commit 8b3bdd9 upstream. On remote cable pull, a zfcp_port keeps its status and only gets ZFCP_STATUS_PORT_LINK_TEST added. Only after an ADISC timeout, we would actually start port recovery and remove ZFCP_STATUS_COMMON_UNBLOCKED which zfcp_sysfs_port_fc_security_show() detected and reported as "unknown" instead of the old and possibly stale zfcp_port->connection_info. Add check for ZFCP_STATUS_PORT_LINK_TEST for timely "unknown" report. Link: https://lore.kernel.org/r/20210702160922.2667874-1-maier@linux.ibm.com Fixes: a17c784 ("scsi: zfcp: report FC Endpoint Security in sysfs") Cc: <stable@vger.kernel.org> #5.7+ Reviewed-by: Benjamin Block <bblock@linux.ibm.com> Signed-off-by: Steffen Maier <maier@linux.ibm.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ea518b7 commit e1261c7

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/s390/scsi/zfcp_sysfs.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,7 @@ static ssize_t zfcp_sysfs_port_fc_security_show(struct device *dev,
487487
if (0 == (status & ZFCP_STATUS_COMMON_OPEN) ||
488488
0 == (status & ZFCP_STATUS_COMMON_UNBLOCKED) ||
489489
0 == (status & ZFCP_STATUS_PORT_PHYS_OPEN) ||
490+
0 != (status & ZFCP_STATUS_PORT_LINK_TEST) ||
490491
0 != (status & ZFCP_STATUS_COMMON_ERP_FAILED) ||
491492
0 != (status & ZFCP_STATUS_COMMON_ACCESS_BOXED))
492493
i = sprintf(buf, "unknown\n");

0 commit comments

Comments
 (0)