ed25516→ed25519#89
Merged
ojarva merged 1 commit intoojarva:masterfrom Jan 30, 2022
Hidden character warning
The head ref may contain hidden characters: "25516\u219225519"
Merged
Conversation
Note: This is direct output from `rgr 25516 -R 25519`: <https://github.com/ElectricRCAircraftGuy/eRCaGuy_dotfiles/blob/master/useful_scripts/rg_replace.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is direct output from
rgr 25516 -R 25519:https://github.com/ElectricRCAircraftGuy/eRCaGuy_dotfiles/blob/master/useful_scripts/rg_replace.sh
Further note: I ran your tests but am not a user of this library. I came across it because someone I know made the same "typo" (it's actually more of a misreading/misremembering of a typo, typo is a bit face-saving hehe but sure, he made a typo, why not) and I wanted to know if it was an alternate algorithm and your library confused matters a bit due to the fact it even appears in your tests, and repeatedly in source, I could not tell. 🙇
Closes #88.