Skip to content

Commit d57f561

Browse files
committed
deps: V8: fix debug backtrace for symbols
The cherry-pick of nodejs#7612 to v4.x (4369055) added in nodejs#9298 wasn't quite correct as it depends on a runtime function %SymbolDescriptiveString that doesn't exist on v4.x. We can use %SymbolDescription instead. Ref: nodejs#7612 Ref: nodejs#9298
1 parent 4d3e158 commit d57f561

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

deps/v8/src/mirror-debugger.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1515,7 +1515,7 @@ PropertyMirror.prototype.name = function() {
15151515

15161516

15171517
PropertyMirror.prototype.toText = function() {
1518-
if (IS_SYMBOL(this.name_)) return %SymbolDescriptiveString(this.name_);
1518+
if (IS_SYMBOL(this.name_)) return %SymbolDescription(this.name_);
15191519
return this.name_;
15201520
};
15211521

deps/v8/test/mjsunit/debug-backtrace-text.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ function listener(event, exec_state, event_data, data) {
106106
// 2: [anonymous]
107107
assertEquals("new Point(x=0, y=0)",
108108
exec_state.frame(0).invocationText());
109-
assertEquals("#<Object>[Symbol(Das Symbol)](x=0, y=0)",
109+
assertEquals("#<Object>[Das Symbol](x=0, y=0)",
110110
exec_state.frame(1).invocationText());
111111
assertEquals("[anonymous]()", exec_state.frame(2).invocationText());
112112
listenerCalled = true;

0 commit comments

Comments
 (0)