-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monitor material based fitting #152
Comments
For completeness, I also attach a plot of output of the command |
maybe we want to move this into the wiki? |
Let's wait for vondele to return. :) My plan was to regularly post those plots here, and see if by some miracle the graphs become more smooth in future... |
This is actually remarkably smooth compared to what we had in SF11 times (classical eval). I don't mind this as an issue, but one could also put this in the readme as an example for this option. |
If we are happy with the model in general, and the smoothness in particular, we may want to adopt the material based WDL model for the dynamic normalisation. It would avoid certain problems of the move based one: such as users being confused that the cp eval depends on the move counter when they use SF for analysis of a single position... |
Below the graphical outputs corresponding to official-stockfish/Stockfish#5002 for |
Below the graphical outputs corresponding to official-stockfish/Stockfish#5070 for |
Here is the latest fitting based on material count: I have prepared the branch https://github.com/robertnurnberg/Stockfish/tree/wdl-material-dynamic to potentially merge into SF. Do we think it is time to do this now? @vondele |
I think this is ready for integration in SF. |
Agreed. Since the anchor now only plays the role of fixing the no-longer-needed constant Once I got that, and then fitted the WDL model with this new parameter, I will open a PR to SF. PS: So the average material at move 32 for my fishtest games is 43.19. |
should the issue be closed, since we now use material based WDL? |
This is not an issue per se, but just a convenient place to regularly check how our material based fitting works.
Below I report on the fits from
./updateWDL.sh --firstrev b59786e750a59d3d7cff2630cf284553f607ed29
(based on move) and frompython scoreWDL.py updateWDL.json --plot save --pgnName update_material.png --momType "material" --momTarget 62 --moveMin 8 --moveMax 120 --materialMin 10 --materialMax 78 --modelFitting optimizeProbability
applied to the same json data (based on material).json data: updateWDL.json.gz
The text was updated successfully, but these errors were encountered: