[FIX] pivot: month granularity sorting

The `month` granularity sorting wasn't working. The issue was that we
were using `Number(value)` instead of `toNumber(value)` to convert
the field value to a number.

closes #6335

Task: 4781810
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

Author: hokolomopo

src/helpers/pivot/spreadsheet_pivot/data_entry_spreadsheet_pivot.ts

@@ -1,4 +1,5 @@
-import { CellValue, EvaluatedCell } from "../../../types";
+import { toNumber } from "../../../functions/helpers";
+import { CellValue, DEFAULT_LOCALE, EvaluatedCell } from "../../../types";
 import { PivotDimension, PivotTableColumn, PivotTableRow } from "../../../types/pivot";
 import { SpreadsheetPivotTable } from "../table_spreadsheet_pivot";
 import { SpreadsheetPivotRuntimeDefinition } from "./runtime_definition_spreadsheet_pivot";
@@ -254,7 +255,9 @@ function compareDimensionValues(dimension: PivotDimension, a: string, b: string)
     return dimension.order === "asc" ? -1 : 1;
   }
   if (dimension.type === "integer" || dimension.type === "date") {
-    return dimension.order === "asc" ? Number(a) - Number(b) : Number(b) - Number(a);
+    return dimension.order === "asc"
+      ? toNumber(a, DEFAULT_LOCALE) - toNumber(b, DEFAULT_LOCALE)
+      : toNumber(b, DEFAULT_LOCALE) - toNumber(a, DEFAULT_LOCALE);
   }
   return dimension.order === "asc" ? a.localeCompare(b) : b.localeCompare(a);
 }

tests/pivots/spreadsheet_pivot/spreadsheet_pivot.test.ts

@@ -535,14 +535,23 @@ describe("Spreadsheet Pivot", () => {
     expect(getEvaluatedGrid(model, "B26:F26")).toEqual([["5", "9", "14", "Total", ""]]);
   });
 
-  test("month should be supported", () => {
+  test("month should be supported and correctly ordered", () => {
     const model = createModelWithPivot("A1:I5");
     updatePivot(model, "1", {
       columns: [{ name: "Created on", granularity: "month", order: "asc" }],
       rows: [],
       measures: [{ name: "Expected Revenue", aggregator: "sum" }],
     });
     setCellContent(model, "A26", `=pivot(1)`);
+    expect(getEvaluatedGrid(model, "B26:F26")).toEqual([
+      ["February 2024", "March 2024", "April 2024", "Total", ""],
+    ]);
+
+    updatePivot(model, "1", {
+      columns: [{ name: "Created on", granularity: "month", order: "desc" }],
+      rows: [],
+      measures: [{ name: "Expected Revenue", aggregator: "sum" }],
+    });
     expect(getEvaluatedGrid(model, "B26:F26")).toEqual([
       ["April 2024", "March 2024", "February 2024", "Total", ""],
     ]);