[FIX] remove all unnecessary accesses to document.defaultView

`document.defaultView` can be null, resulting in errors if we depend on
it for calling `getSelection`. This is easily fixed given that
`document` has its own `getSelection` method which does exactly what we
were expecting from that of the `window` object.

This removes all these unnecessary `defaultView` accesses.

Author: Zynton

src/commands.js

@@ -32,7 +32,7 @@ const TEXT_CLASSES_REGEX = /\btext-[^\s]*\b/g;
 const BG_CLASSES_REGEX = /\bbg-[^\s]*\b/g;
 
 function insert(editor, data, isText = true) {
-    const selection = editor.document.defaultView.getSelection();
+    const selection = editor.document.getSelection();
     const range = selection.getRangeAt(0);
     let startNode;
     let insertBefore = false;
@@ -45,7 +45,7 @@ function insert(editor, data, isText = true) {
     } else {
         editor.deleteRange(selection);
     }
-    startNode = startNode || editor.document.defaultView.getSelection().anchorNode;
+    startNode = startNode || editor.document.getSelection().anchorNode;
     if (startNode.nodeType === Node.ELEMENT_NODE) {
         if (selection.anchorOffset === 0) {
             startNode.prepend(editor.document.createTextNode(''));
@@ -82,7 +82,7 @@ function insert(editor, data, isText = true) {
     return insertedNodes;
 }
 function align(editor, mode) {
-    const sel = editor.document.defaultView.getSelection();
+    const sel = editor.document.getSelection();
     const visitedBlocks = new Set();
     const traversedNode = getTraversedNodes(editor.editable);
     for (const node of traversedNode) {
@@ -147,7 +147,7 @@ function hasColor(element, mode) {
  * which the wanted style should be applied
  */
 function applyInlineStyle(editor, applyStyle) {
-    const sel = editor.document.defaultView.getSelection();
+    const sel = editor.document.getSelection();
     const { startContainer, startOffset, endContainer, endOffset } = sel.getRangeAt(0);
     const { anchorNode, anchorOffset, focusNode, focusOffset } = sel;
     const direction = getCursorDirection(anchorNode, anchorOffset, focusNode, focusOffset);
@@ -311,7 +311,7 @@ export const editorCommands = {
 
     // Link
     createLink: (editor, link, content) => {
-        const sel = editor.document.defaultView.getSelection();
+        const sel = editor.document.getSelection();
         if (content && !sel.isCollapsed) {
             editor.deleteRange(sel);
         }
@@ -329,7 +329,7 @@ export const editorCommands = {
         }
     },
     unlink: editor => {
-        const sel = editor.document.defaultView.getSelection();
+        const sel = editor.document.getSelection();
         // we need to remove the contentEditable isolation of links
         // before we apply the unlink, otherwise the command is not performed
         // because the content editable root is the link
@@ -469,7 +469,7 @@ export const editorCommands = {
         const tdsHtml = new Array(colCount).fill('<td><br></td>').join('');
         const trsHtml = new Array(rowCount).fill(`<tr>${tdsHtml}</tr>`).join('');
         const tableHtml = `<table class="table table-bordered"><tbody>${trsHtml}</tbody></table>`;
-        const sel = editor.document.defaultView.getSelection();
+        const sel = editor.document.getSelection();
         if (!sel.isCollapsed) {
             editor.deleteRange(sel);
         }

src/editor.js

@@ -890,7 +890,7 @@ export class OdooEditor extends EventTarget {
 
         let hiliteColor = params.hiliteColor;
         if (!hiliteColor) {
-            const sel = this.document.defaultView.getSelection();
+            const sel = this.document.getSelection();
             if (sel.rangeCount) {
                 const endContainer = closestElement(sel.getRangeAt(0).endContainer);
                 const hiliteColorRgb = getComputedStyle(endContainer).backgroundColor;
@@ -921,7 +921,7 @@ export class OdooEditor extends EventTarget {
      * @returns {?}
      */
     _applyRawCommand(method, ...args) {
-        const sel = this.document.defaultView.getSelection();
+        const sel = this.document.getSelection();
         if (!sel.isCollapsed && BACKSPACE_FIRST_COMMANDS.includes(method)) {
             this.deleteRange(sel);
             if (BACKSPACE_ONLY_COMMANDS.includes(method)) {
@@ -1008,7 +1008,7 @@ export class OdooEditor extends EventTarget {
      * @returns {Object}
      */
     _computeHistoryCursor() {
-        const sel = this.document.defaultView.getSelection();
+        const sel = this.document.getSelection();
         if (!sel.anchorNode) {
             return this._latestComputedCursor;
         }
@@ -1072,7 +1072,7 @@ export class OdooEditor extends EventTarget {
             this.toolbar.style.visibility = 'visible';
         }
 
-        const sel = this.document.defaultView.getSelection();
+        const sel = this.document.getSelection();
         if (!sel.anchorNode) {
             show = false;
         }
@@ -1168,7 +1168,7 @@ export class OdooEditor extends EventTarget {
         let isBottom = false;
         this.toolbar.classList.toggle('toolbar-bottom', false);
         this.toolbar.style.maxWidth = this.editable.offsetWidth - OFFSET * 2 + 'px';
-        const sel = this.document.defaultView.getSelection();
+        const sel = this.document.getSelection();
         const range = sel.getRangeAt(0);
         const isSelForward =
             sel.anchorNode === range.startContainer && sel.anchorOffset === range.startOffset;
@@ -1255,7 +1255,7 @@ export class OdooEditor extends EventTarget {
                 }
             } else if (['insertText', 'insertCompositionText'].includes(ev.inputType)) {
                 // insertCompositionText, courtesy of Samsung keyboard.
-                const selection = this.document.defaultView.getSelection();
+                const selection = this.document.getSelection();
                 // Detect that text was selected and change behavior only if it is the case,
                 // since it is the only text insertion case that may cause problems.
                 if (anchorNode !== focusNode || anchorOffset !== focusOffset) {
@@ -1289,7 +1289,7 @@ export class OdooEditor extends EventTarget {
         // representation of the key. In this case, call `deleteRange` before
         // inserting the printed representation of the character.
         if (/^.$/u.test(ev.key) && !ev.ctrlKey && !ev.metaKey) {
-            const selection = this.document.defaultView.getSelection();
+            const selection = this.document.getSelection();
             if (selection && !selection.isCollapsed) {
                 this.deleteRange(selection);
             }
@@ -1336,7 +1336,7 @@ export class OdooEditor extends EventTarget {
         // that to the command execution or the 'input' event handler.
         this._computeHistoryCursor();
 
-        const selection = this.document.defaultView.getSelection();
+        const selection = this.document.getSelection();
         const isSelectionInEditable =
             !selection.isCollapsed &&
             this.editable.contains(selection.anchorNode) &&
@@ -1464,7 +1464,7 @@ export class OdooEditor extends EventTarget {
      */
     _onDrop(ev) {
         ev.preventDefault();
-        const sel = this.document.defaultView.getSelection();
+        const sel = this.document.getSelection();
         let isInEditor = false;
         let ancestor = sel.anchorNode;
         while (ancestor && !isInEditor) {
@@ -1488,7 +1488,7 @@ export class OdooEditor extends EventTarget {
                     const range = this.document.caretRangeFromPoint(ev.clientX, ev.clientY);
                     setCursor(range.startContainer, range.startOffset);
                 }
-                insertText(this.document.defaultView.getSelection(), pastedText);
+                insertText(this.document.getSelection(), pastedText);
             });
         }
         this.historyStep();
@@ -1606,7 +1606,7 @@ export class OdooEditor extends EventTarget {
      * Fix the current selection range in case the range start or end inside a fontAwesome node
      */
     _fixFontAwesomeSelection() {
-        const selection = this.document.defaultView.getSelection();
+        const selection = this.document.getSelection();
         if (
             selection.isCollapsed ||
             (selection.anchorNode &&

src/tests/utils.js

@@ -369,7 +369,7 @@ export async function createLink(editor, content) {
 }
 
 export async function insertText(editor, text) {
-    const sel = document.defaultView.getSelection();
+    const sel = document.getSelection();
     insertTextSel(sel, text);
     sel.collapseToEnd();
     editor.historyStep();

src/utils/utils.js

@@ -481,7 +481,7 @@ export function setCursor(
         : getNormalizedCursorPosition(focusNode, focusOffset, normalize);
 
     const direction = getCursorDirection(anchorNode, anchorOffset, focusNode, focusOffset);
-    const sel = document.defaultView.getSelection();
+    const sel = document.getSelection();
     const range = new Range();
     if (direction === DIRECTIONS.RIGHT) {
         range.setStart(anchorNode, anchorOffset);
@@ -563,7 +563,7 @@ export function getTraversedNodes(editable) {
  */
 export function getSelectedNodes(editable) {
     const document = editable.ownerDocument;
-    const sel = document.defaultView.getSelection();
+    const sel = document.getSelection();
     if (!sel.rangeCount) {
         return [];
     }
@@ -587,7 +587,7 @@ export function getSelectedNodes(editable) {
  * @returns {Range}
  */
 export function getDeepRange(editable, { range, sel, splitText, select, correctTripleClick } = {}) {
-    sel = sel || editable.ownerDocument.defaultView.getSelection();
+    sel = sel || editable.ownerDocument.getSelection();
     range = range ? range.cloneRange() : sel.rangeCount && sel.getRangeAt(0).cloneRange();
     if (!range) return;
     let start = range.startContainer;
@@ -706,7 +706,7 @@ export function getDeepestPosition(node, offset) {
 }
 
 export function getCursors(document) {
-    const sel = document.defaultView.getSelection();
+    const sel = document.getSelection();
     if (
         getCursorDirection(sel.anchorNode, sel.anchorOffset, sel.focusNode, sel.focusOffset) ===
         DIRECTIONS.LEFT
@@ -722,7 +722,7 @@ export function getCursors(document) {
 }
 
 export function preserveCursor(document) {
-    const sel = document.defaultView.getSelection();
+    const sel = document.getSelection();
     const cursorPos = [sel.anchorNode, sel.anchorOffset, sel.focusNode, sel.focusOffset];
     return replace => {
         replace = replace || new Map();
@@ -881,7 +881,7 @@ export function containsUnremovable(node) {
 }
 
 export function getInSelection(document, selector) {
-    const selection = document.defaultView.getSelection();
+    const selection = document.getSelection();
     const range = !!selection.rangeCount && selection.getRangeAt(0);
     return (
         range &&