Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulma modals break because of bulma-o-steps #37

Open
eriknaslund opened this issue May 24, 2021 · 0 comments
Open

Bulma modals break because of bulma-o-steps #37

eriknaslund opened this issue May 24, 2021 · 0 comments

Comments

@eriknaslund
Copy link

eriknaslund commented May 24, 2021

Bulma 0.9.0 and 0.9.2 suffers from a slightly broken modal when the scss for bulma-o-steps is included.
The .modal element should have position: fixed, but it gets position: absolute instead, which causes the background to only fill the top part of the screen if you scroll down.

I believe this is the same issue as in:

The workaround (as posted in the linked issues) is to simply change your scss import from bulma-steps.sass to index.sass, like this:

- @import "../../lib/bulma-o-steps/bulma-step";
+ @import "../../lib/bulma-o-steps/index";

I'm guessing the problem originates from that fact that bulma-o-steps provides a big chunk of SASS (utilities/*) which seems to be copied from Bulma itself. At least that's what it looks like after a quick glance. This seems a bit brittle since there's a high potential for breakage during Bulma version upgrades.

I don't know SASS well enough to suggest a sensible workaround. However, when I just included the index.sass myself, and used just used the (already included) utilities from my Bulma install, then things worked great. Could the solution perhaps be as simple as:

  1. Get rid of utilities/* and bulma-steps.sass from bulma-o-steps.
  2. Change the docs to tell people to import bulma first, and then import bulma-o-steps afterwards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant