Skip to content

Commit

Permalink
fix: remove deprecations (#73)
Browse files Browse the repository at this point in the history 
BREAKING CHANGE: removes deprecated properties

- `ClosedEvent#commit`
- `ProjectCard#projectColumn`
- `ReferencedEvent#isCrossReference`
- `Repository#license`
- `RepositoryInfo#license`
- `ReviewRequest#reviewer`
- `ReviewRequestRemovedEvent#subject`
- `ReviewRequestedEvent#subject`
  • Loading branch information
@octokitbot @gr2m
octokitbot authored and gr2m committed Jul 3, 2018
1 parent ac9defd commit 5612ea0
Show file tree
Hide file tree
Showing 2 changed files with 119 additions and 259 deletions.
67 changes: 13 additions & 54 deletions schema.graphql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -411,9 +411,6 @@ type ClosedEvent implements Node & UniformResourceLocatable {
# Object which triggered the creation of this event.
closer: Closer

# Identifies the commit associated with the 'closed' event.
commit: Commit @deprecated(reason: "`ClosedEvent` may be associated with other objects than a commit. Use ClosedEvent.closer instead. Removal on 2019-01-01 UTC.")

# Identifies the date and time when the object was created.
createdAt: DateTime!
id: ID!
Expand Down Expand Up @@ -3338,7 +3335,7 @@ enum OrderDirection {
}

# An account on GitHub, with one or more owners, that has repositories, members and teams.
type Organization implements Actor & Node & ProjectOwner & RepositoryOwner & UniformResourceLocatable {
type Organization implements Actor & Node & ProjectOwner & RegistryPackageOwner & RegistryPackageSearch & RepositoryOwner & UniformResourceLocatable {
# A URL pointing to the organization's public avatar.
avatarUrl(
# The size of the resulting square image.
Expand Down Expand Up @@ -3818,9 +3815,6 @@ type ProjectCard implements Node {
# The project that contains this card.
project: Project!

# The column that contains this card.
projectColumn: ProjectColumn! @deprecated(reason: "The associated column may be null if the card is in a pending state. Use `ProjectCard.column` instead. Removal on 2019-01-01 UTC.")

# The HTTP path for this card
resourcePath: URI!

Expand Down Expand Up @@ -5478,9 +5472,6 @@ type ReferencedEvent implements Node {
createdAt: DateTime!
id: ID!

# Reference originated in a different repository.
isCrossReference: Boolean! @deprecated(reason: "`isCrossReference` will be renamed. Use `ReferencedEvent.isCrossRepository` instead. Removal on 2019-01-01 UTC.")

# Reference originated in a different repository.
isCrossRepository: Boolean!

Expand All @@ -5494,6 +5485,16 @@ type ReferencedEvent implements Node {
# Any referencable object
union ReferencedSubject = Issue | PullRequest

# Represents an owner of a registry package.
interface RegistryPackageOwner {
id: ID!
}

# Represents an interface to search packages on an object.
interface RegistryPackageSearch {
id: ID!
}

# A release contains the content for a release.
type Release implements Node & UniformResourceLocatable {
# The author of the release
Expand Down Expand Up @@ -5761,7 +5762,7 @@ type ReopenedEvent implements Node {
}

# A repository contains the content for a project.
type Repository implements Node & ProjectOwner & RepositoryInfo & Starrable & Subscribable & UniformResourceLocatable {
type Repository implements Node & ProjectOwner & RegistryPackageOwner & RepositoryInfo & Starrable & Subscribable & UniformResourceLocatable {
# A list of users that can be assigned to issues in this repository.
assignableUsers(
# Returns the elements in the list that come after the specified cursor.
Expand Down Expand Up @@ -5997,9 +5998,6 @@ type Repository implements Node & ProjectOwner & RepositoryInfo & Starrable & Su
orderBy: LanguageOrder
): LanguageConnection

# The license associated with the repository
license: String @deprecated(reason: "Field `license` will be replaced by a more detailed license object. Use `Repository.licenseInfo` instead. Removal on 2019-01-01 UTC.")

# The license associated with the repository
licenseInfo: License

Expand Down Expand Up @@ -6447,9 +6445,6 @@ interface RepositoryInfo {
# Identifies if the repository is private.
isPrivate: Boolean!

# The license associated with the repository
license: String @deprecated(reason: "Field `license` will be replaced by a more detailed license object. Use `Repository.licenseInfo` instead. Removal on 2019-01-01 UTC.")

# The license associated with the repository
licenseInfo: License

Expand Down Expand Up @@ -6820,9 +6815,6 @@ type ReviewRequest implements Node {

# The reviewer that is requested.
requestedReviewer: RequestedReviewer

# Identifies the author associated with this review request.
reviewer: User @deprecated(reason: "Field `reviewer` will be changed in favor of returning a union type. Use `ReviewRequest.requestedReviewer` instead. Removal on 2019-01-01 UTC.")
}

# The connection type for ReviewRequest.
Expand Down Expand Up @@ -6863,9 +6855,6 @@ type ReviewRequestRemovedEvent implements Node {

# Identifies the reviewer whose review request was removed.
requestedReviewer: RequestedReviewer

# Identifies the user whose review request was removed.
subject: User @deprecated(reason: "`subject` will be renamed. Use `ReviewRequestRemovedEvent.requestedReviewer` instead. Removal on 2019-01-01 UTC.")
}

# Represents an 'review_requested' event on a given pull request.
Expand All @@ -6882,9 +6871,6 @@ type ReviewRequestedEvent implements Node {

# Identifies the reviewer whose review was requested.
requestedReviewer: RequestedReviewer

# Identifies the user whose review was requested.
subject: User @deprecated(reason: "`subject` will be renamed. Use `ReviewRequestedEvent.requestedReviewer` instead. Removal on 2019-01-01 UTC.")
}

# The results of a search.
Expand Down Expand Up @@ -7991,7 +7977,7 @@ type UpdateTopicsPayload {
}

# A user is an individual's account on GitHub that owns repositories and can make new content.
type User implements Actor & Node & RepositoryOwner & UniformResourceLocatable {
type User implements Actor & Node & RegistryPackageOwner & RegistryPackageSearch & RepositoryOwner & UniformResourceLocatable {
# A URL pointing to the user's public avatar.
avatarUrl(
# The size of the resulting square image.
Expand Down Expand Up @@ -8025,33 +8011,6 @@ type User implements Actor & Node & RepositoryOwner & UniformResourceLocatable {
# The user's public profile company as HTML.
companyHTML: HTML!

# A list of repositories that the user recently contributed to.
contributedRepositories(
# Affiliation options for repositories returned from the connection
affiliations: [RepositoryAffiliation] = [OWNER, COLLABORATOR]

# Returns the elements in the list that come after the specified cursor.
after: String

# Returns the elements in the list that come before the specified cursor.
before: String

# Returns the first _n_ elements from the list.
first: Int

# If non-null, filters repositories according to whether they have been locked
isLocked: Boolean

# Returns the last _n_ elements from the list.
last: Int

# Ordering options for repositories returned from the connection
orderBy: RepositoryOrder

# If non-null, filters repositories according to privacy
privacy: RepositoryPrivacy
): RepositoryConnection! @deprecated(reason: "Arguments for connection `contributedRepositories` are getting redesigned. Use `User.repositoriesContributedTo` instead. Removal on 2019-01-01 UTC.")

# Identifies the date and time when the object was created.
createdAt: DateTime!

Expand Down
Loading

0 comments on commit 5612ea0

Please sign in to comment.