-
Notifications
You must be signed in to change notification settings - Fork 194
[wasm] Option to implement OCaml strings with JavaScript strings #1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vouillon
wants to merge
16
commits into
master
Choose a base branch
from
js-strings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7622533
to
1e6911d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 59 out of 59 changed files in this pull request and generated no comments.
2185d26
to
759358a
Compare
cae36fc
to
7494238
Compare
6d4097d
to
787eed2
Compare
This reverts commit a0133d0.
787eed2
to
eb9aa27
Compare
vouillon
commented
Jun 12, 2025
vouillon
commented
Jun 12, 2025
vouillon
commented
Jun 12, 2025
vouillon
commented
Jun 12, 2025
vouillon
commented
Jun 12, 2025
vouillon
commented
Jun 13, 2025
vouillon
commented
Jun 13, 2025
vouillon
commented
Jun 18, 2025
9890456
to
0250252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.