[draft] Implement the popover API.
#1734
Conversation
| method showPopover : unit meth | ||
|
|
||
| method showPopover_options : _ -> unit meth | ||
|
|
||
| method togglePopover : bool t meth | ||
|
|
||
| method togglePopover_force : bool t -> bool t meth | ||
|
|
||
| method togglePopover_options : _ -> bool t meth | ||
|
|
There was a problem hiding this comment.
According to the specs, these methods accept a dictionary as a parameter for passing options. How would that be reflected in Js_of_ocaml?
There was a problem hiding this comment.
I think there is an example in lib/js_of_ocaml/eventSource.ml
| method onbeforetoggle : ('self t, toggleEvent t) event_listener writeonly_prop | ||
|
|
||
| method ontoggle : ('self t, toggleEvent t) event_listener writeonly_prop | ||
|
|
There was a problem hiding this comment.
There are similar methods related to event handlers in this file that have the prop type instead of writeonly_prop. In fact, the ontoggle method initially used the former type. Is this new version correct?
There was a problem hiding this comment.
writeonly_prop is often used for situation where the property might be undefined.
|
I apologies for the extra long delay reviewing your PR. |
|
|
||
| method popovertarget : element t opt prop | ||
|
|
||
| method popovertargetaction : js_string t prop |
There was a problem hiding this comment.
Shouldn't this be popoverTargetAction ?
| @@ -1284,6 +1308,10 @@ class type buttonElement = object | |||
| method _type : js_string t readonly_prop | |||
|
|
|||
| method value : js_string t prop | |||
|
|
|||
| method popovertarget : element t opt prop | |||
There was a problem hiding this comment.
Shouldn't this be popoverTargetElement ?
Hello,
This PR adds support for the
popoverAPI.See:
Please let me know of any issue; in fact, I would appreciate your input regarding a couple things (see below).
Cheers,