Skip to content

Lib: add message event types and PerformanceObserver #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

pmwhite
Copy link
Contributor

@pmwhite pmwhite commented Aug 23, 2021

No description provided.

@hhugo
Copy link
Member

hhugo commented Oct 7, 2021

should we also bind PerformanceObserver.supportedEntryTypes ?

@hhugo
Copy link
Member

hhugo commented Oct 7, 2021

Also, can you rebase the branch ? The changelog will need to be updated.

@pmwhite
Copy link
Contributor Author

pmwhite commented Nov 3, 2021

Sorry, took me a while to get back to this PR. I attempted the rebase, and now apparently there are 72 commits. I don't know why, because my fork only looks like it's 7 commits ahead.

@hhugo
Copy link
Member

hhugo commented Nov 3, 2021

It looks like you introduced a merge commit in your branch. Try git rebase -i to only rebase your commits and dropping the merge commit on the way.

@pmwhite
Copy link
Contributor Author

pmwhite commented Nov 6, 2021

I tried to fix this with git rebase -i, but it seemed like I think my previous actions had made the fix more complicated than just removing the merge commit. I figured it would be easier to reset my fork to upstream master and re-apply the diff of this PR as one commit. Sadly, it had the side-effect of closing this PR automaticaly, so I've re-opened it in #1164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants