-
Notifications
You must be signed in to change notification settings - Fork 194
Avoid polymorphic comparison over float values #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you add a changelog entry ? |
I have added a changelog entry and pushed additional commits |
I've reformated the code with |
Thanks for the bugfix |
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Aug 5, 2020
…ml-ppx, js_of_ocaml-lwt, js_of_ocaml-toplevel, js_of_ocaml-tyxml, js_of_ocaml and js_of_ocaml-ppx_deriving_json (3.7.0) CHANGES: ## Features/Changes * Runtime: allow one to override xmlHttpRequest.create (ocsigen/js_of_ocaml#1002) * Runtime: Change the semantic of MlBytes.toString, introduce MlBytes.toUtf16 * Compiler: initial support for OCaml 4.11 * Compiler: initial support for OCaml 4.12 * Compiler: improve the javascript parser by relying on menhir incremental api. * Compiler: Eliminate allocation of dummy function ocsigen/js_of_ocaml#1013 ## Bug fixes * Compiler: fix code generation for recursive function under for-loops (ocsigen/js_of_ocaml#1009) * Compiler: the jsoo compiler compiled to javascript was not behaving correctly when parsing constant in the from the bytecode * Compiler: make sure inline doesn't loop indefinitly (ocsigen/js_of_ocaml#1043) * Compiler: fix bug generating invalid javascript for if-then construct (ocsigen/js_of_ocaml#1046) * Compiler: do not use polymorphic comparison when joining float values (ocsigen/js_of_ocaml#1048) * Lib: Rename msg to message in Worker (ocsigen/js_of_ocaml#1037) * Lib: fix graphics_js when build with separate compilation (ocsigen/js_of_ocaml#1029)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While randomly walking through the code, I noticed something similar
to an old flambda bug. Indeed, with master, the following code (copied
from this pull request) prints
inf
instead of-inf
:The culprit is the use of the polymorphic equality on float values by a join
operation in the
Flow
module. This pull request ensure that the equalityfunction over
Code.constant
value does not use the polymorphic equality.