Effects: calling convention fix

Author: vouillon

compiler/tests-jsoo/lib-effects/dune

@@ -8,6 +8,6 @@
   ;; This requires the unreleased dune 3.7 to work
   (enabled_if true)
   (flags -allow-output-patterns)
-  (modes js))
+  (modes js best))
  (preprocess
   (pps ppx_expect)))

compiler/tests-jsoo/lib-effects/state.ml

@@ -262,14 +262,9 @@ let main () : unit =
 
 let%expect_test _ =
   ignore (IntCell.run ~init:0 (fun () -> StrCell.run ~init:"" main));
-  [%expect.unreachable]
-  [@@expect.uncaught_exn
-    {|
-  (Failure "TypeError: a is not a function")
-  Trailing output
-  ---------------
-  0
-  42
-  21
-  Hello...
-  ...World! |}]
+  [%expect {|
+    0
+    42
+    21
+    Hello...
+    ...World! |}]

compiler/tests-jsoo/lib-effects/transaction.ml

@@ -118,5 +118,8 @@ let%expect_test _ =
     save
     T1: Before abort 21
     before raise
-    inner exception: Stack overflow
-    outer exception: Failure("TypeError: a is not a function") |}]
+    restore
+    restore
+    raise
+    T0: T1 aborted with 21
+    T0: 10 |}]

runtime/effect.js

@@ -120,20 +120,20 @@ function caml_perform_effect(eff, cont, k0) {
 }
 
 //Provides: caml_alloc_stack
-//Requires: caml_pop_fiber, caml_fiber_stack
+//Requires: caml_pop_fiber, caml_fiber_stack, caml_call_gen
 //If: effects
 function caml_alloc_stack(hv, hx, hf) {
   function hval(x) {
     // Call [hv] in the parent fiber
     var f=caml_fiber_stack.h[1];
     var k=caml_pop_fiber();
-    return f(x, k);
+    return caml_call_gen(f, [x, k]);
   }
   function hexn(e) {
     // Call [hx] in the parent fiber
     var f=caml_fiber_stack.h[2];
     var k=caml_pop_fiber();
-    return f(e, k);
+    return caml_call_gen(f, [e, k]);
   }
   return [0, hval, [0, hexn, 0], [0, hv, hx, hf], 0];
 }