Fix caml_js_on_ie (#1493)

vouillon · web-flow · commit 8cd97dc91bcd · 2023-07-26T15:31:45.000+02:00
Recent versions of node define `navigator` but not `navigator.userAgent`.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,7 @@
+# Dev (2023-??-??) - ??
+
+* Runtime: fix Dom_html.onIE (#1493)
+
 # 5.4.0 (2023-07-06) - Lille
 
 ## Bug fixes
diff --git a/runtime/jslib_js_of_ocaml.js b/runtime/jslib_js_of_ocaml.js
@@ -22,7 +22,8 @@
 //Provides: caml_js_on_ie const
 function caml_js_on_ie () {
   var ua =
-      globalThis.navigator?globalThis.navigator.userAgent:"";
+      (globalThis.navigator&&globalThis.navigator.userAgent)
+      ?globalThis.navigator.userAgent:"";
   return ua.indexOf("MSIE") != -1 && ua.indexOf("Opera") != 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,8 @@`
`22`	`22`	`//Provides: caml_js_on_ie const`
`23`	`23`	`function caml_js_on_ie () {`
`24`	`24`	`var ua =`
`25`		`- globalThis.navigator?globalThis.navigator.userAgent:"";`
	`25`	`+ (globalThis.navigator&&globalThis.navigator.userAgent)`
	`26`	`+ ?globalThis.navigator.userAgent:"";`
`26`	`27`	`return ua.indexOf("MSIE") != -1 && ua.indexOf("Opera") != 0;`
`27`	`28`	`}`
`28`	`29`