Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: plugin install can fail due to dependencies releasing incompatible versions #815

Closed
mars opened this issue Aug 19, 2021 · 0 comments · Fixed by #776
Closed

Bug: plugin install can fail due to dependencies releasing incompatible versions #815

mars opened this issue Aug 19, 2021 · 0 comments · Fixed by #776

Comments

@mars
Copy link

mars commented Aug 19, 2021

It seems that plugin installation does not honor the plugin's yarn.lock, but instead installs dependencies based on the range-specifications in package.json.

This results in plugins that are not truly versioned. Two people install the same plugin versions at different times, and due to releases made by third-party dependencies, can end up with plugins that work (or fail) differently.

The example that we experienced this morning is:

sfdx plugins:install @salesforce/plugin-functions
…
Installing plugin functions...
…
error boolean@3.1.3: The engine "node" is incompatible with this module. Expected version ">= 16.7.0". Got "14.17.5"
error Found incompatible module.
    Error: yarn add @salesforce/plugin-functions@latest --non-interactive 
    --mutex=file:/home/circleci/.local/share/sfdx/yarn.lock 
    --preferred-cache-folder=/home/circleci/.cache/sfdx/yarn --check-files 

Could plugin installation be enhanced to honor a lock file when present? yarn.lock seems like the standard in oclif.

@mars mars changed the title Bug: plugin install can fail due dependencies releasing incompatible versions Bug: plugin install can fail due to dependencies releasing incompatible versions Aug 19, 2021
@mdonnalley mdonnalley transferred this issue from oclif/oclif Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant