[BUG] Yarn hoisting behaviour depends on plugin installation order

[ethan-sargent]

Description

We are installing multiple plugins into the Salesforce CLI which uses this plugin.

Currently, it seems that changing the order we install plugins in changes yarn's hoisting behaviour, which can cause incorrect module versions to be required in a plugin.

Expected behaviour

The order plugins are installed should not cause changes in execution behaviour.

Current behaviour

The order plugins are installed causes dependencies to be incorrectly required, potentially causing significantly different behaviour depending on installation order.

Screenshots

Failure case:

Success case:

Steps to reproduce

Success case Dockerfile:

FROM node:18
RUN npm install -g @salesforce/cli 
RUN sf plugins install @salesforce/sfdx-scanner && \
    sf plugins install @salesforce/plugin-packaging && \
    sf plugins install @salesforce/plugin-community && \
    echo y | sf plugins install sfdx-git-delta && \
    sf plugins install sfdmu && \
    sf plugins install @salesforce/plugin-signups

Failure case Dockerfile:

FROM node:18
RUN npm install -g @salesforce/cli 
RUN sf plugins install @salesforce/sfdx-scanner && \
    sf plugins install @salesforce/plugin-packaging && \
    sf plugins install @salesforce/plugin-community && \
    sf plugins install @salesforce/plugin-signups && \
    sf plugins install sfdmu && \
    echo y | sf plugins install sfdx-git-delta

Build the dockerfiles and run any command from the @salesforce/sfdx-scanner plugin.

Command used when debugging this was sfdx scanner:rule:add --language xml --path temp.xml.

sfdx version information:

 CLI Version:
	@salesforce/cli/2.4.10

 Architecture:
	linux-x64

 Node Version:
	node-v18.17.1

 Plugin Version:
	@oclif/plugin-autocomplete 2.3.6 (core)
	@oclif/plugin-commands 2.2.21 (core)
	@oclif/plugin-help 5.2.16 (core)
	@oclif/plugin-not-found 2.3.36 (core)
	@oclif/plugin-plugins 3.2.0 (core)
	@oclif/plugin-search 0.0.22 (core)
	@oclif/plugin-update 3.1.30 (core)
	@oclif/plugin-version 1.3.8 (core)
	@oclif/plugin-warn-if-update-available 2.0.46 (core)
	@oclif/plugin-which 2.2.29 (core)
	@salesforce/cli 2.4.10 (core)
	apex 2.3.10 (core)
	auth 2.8.12 (core)
	community 2.3.11 (user)
	data 2.5.5 (core)
	deploy-retrieve 1.17.2 (core)
	info 2.6.38 (core)
	limits 2.3.29 (core)
	login 1.2.25 (core)
	org 2.9.30 (core)
	packaging 1.22.2 (user)
	schema 2.3.22 (core)
	settings 1.4.24 (core)
	signups 1.4.33 (user)
	sobject 0.2.2 (core)
	source 2.10.30 (core)
	telemetry 2.2.5 (core)
	templates 55.5.9 (core)
	trust 2.5.4 (core)
	user 2.3.28 (core)
	@salesforce/sfdx-scanner 3.15.0 (user)
	sfdmu 4.30.0 (user)
	sfdx-git-delta 5.24.2 (user)

 OS and Version:
	Linux 6.4.7-200.fc38.x86_64

 Shell:
	bash

 Root Path:
	/usr/local/lib/node_modules/@salesforce/cli

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.