[YAML, Sw eng] [Roberto] Review YAML update

[idiom-bytes]

Motivation

• Review YAML + Keep track of changes here + Merge changes into YAML
• Use latest version of Azure VPS to deploy a vanilla barge environment to test against PR

Problems found, separate issues already created

• #416 No Feeds Found - data_pp.py changes pair standards
• #417 Barge pdr-publisher deploys pair <BTC/TUSD> that should be replaced by <BTC/USDT> pair
• #418 pdr-trader does not work on VPS, throws an exception because it's trying to buy from <BTC/TUSD>
• #419 pdr-trueval does not work on VPS, barge runner does not provide the right args

These are being tracked via the main YAML epic, #400

Problems found, separate issues not created yet

• (add to me)

[idiom-bytes]

Hi @trentmc while running through vps.md Barge I am noticing the following
(1) Important - Bots are breaking because they can't find a feed. (changes in pair_str from "/" to "-")
(2) Minor - barge/pdr-publisher deploys BTC/TUSD

I've been merging your latest code from yaml-cli2 over to this branch (issue411) such that I'm running off your codebase vs. VPS deployment.

[1. No Feeds Found - data_pp.py changes pair standards]
Problems between data_pp.py and subgraph.py such that contracts ["ntfData"]["pair"] doesn't match pair_str.

Problem:

1. data_pp.pair_strs now returns ['ETH-USDT'], but web3_pp.get_feeds() expects ['ETH/USDT']
2. I believe we should maintain all pair definitions such as to only use "/", and avoid using "-" everywhere. 1 or the other, not both. I'm not sure what the motivation was, but at the contract level and many other places (i,.e, APIs) this breaks convention. I don't believe this should be adopted.
3. I'm not sure how this isn't failing the tests ATM... I'm gonna run testing flow for barge vps, so i can see what's going on with coverage

TLDR; In base_predictoor_agent.py ln 41

  # TODO: data_pp.pair_strs returns ['ETH-USDT'], but web3_pp.get_feeds() expects ['ETH/USDT']
  x = list(self.ppss.data_pp.pair_strs)
  y = list([self.ppss.data_pp.timeframe])
  z = list(self.ppss.data_pp.exchange_strs)

  cand_feeds = self.ppss.web3_pp.get_feeds(x, y, z)

subgraph.py - ln 217, 218

info725 = contract["token"]["nft"]["nftData"]

[2. Barge BTC/TUSD]
Barge deploys BTC/TUSD, not BTC/USDT. TUSD is not a ValidQuote.
We should perhaps create a ticket to update pdr-publisher, to deploy BTC/USDT.

Until then, I have updated vps.md to change ppss.yaml from BTC/USDT => ETH/USDT

[idiom-bytes]

Answer as to why this isn't covered in tests.

1. predictoor agent mocks the query, and doesn't enforce any pair_str format from the contract

@enforce_types
def run_agent_test(tmpdir, monkeypatch, predictoor_agent_class):
    monkeypatch.setenv("PRIVATE_KEY", PRIV_KEY)

    ppss = _ppss(tmpdir)

    mock_query = MockQuery(ppss.data_pp)
    monkeypatch.setattr(
        "pdr_backend.ppss.web3_pp.query_feed_contracts",
        mock_query.mock_query_feed_contracts,
    )

2. test_web3_pp.py assumes that contract returns pair: BTC-ETH but that is not correct

FEED_DICT = {  # info inside a predictoor contract
    "name": "Contract Name",
    "address": ADDR,
    "symbol": "test",
    "seconds_per_epoch": 300,
    "seconds_per_subscription": 60,
    "trueval_submit_timeout": 15,
    "owner": "0xowner",
    "pair": "BTC-ETH", # This is not correct
    "timeframe": "1h",
    "source": "binance",
}

[idiom-bytes]

[3. Issues with pdr-trader on VPS]
On remote azure VM, barge's deployment of pdr_trader also fails because it's default runner is configured to buy from BTC/TUSD contract, but pairstr.py::verify_quote_str` throws a ValueError

[idiom-bytes]

[4. Issues with pdr-trueval on VPS]
On remote azure, barge deployment of pdr-trueval.yaml doesn't seem to be running correctly. I believe the barge configuration isn't passing the required args to start the runner.

pdr-trueval.yaml currently, just passes command: trueval instead, should be configured to pass in the module (trueval) + command (1) like the image below

I believe this might have been broken for a bit of time... and that no tests/ci/cd cover this.

Obviously, barge will also need to be updated such that the .yaml files use the pdr cli and are working.

[trentmc]

Thanks @idiom-bytes ! This is very useful. I will go through and fix these. And make tests to catch them.

UPDATE: I created a github issue for each of 1-2-3-4. I updated this issue's description accordingly.