Fix odp set dirty #333
Merged
Fix odp set dirty #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackShi148
force-pushed
the
fix_odp_set_dirty
branch
from
e8e44e3 to
ea0aca5
Compare
WeiXinChan
reviewed
May 8, 2025
JackShi148
force-pushed
the
fix_odp_set_dirty
branch
from
8a8315a to
7243b68
Compare
JackShi148
force-pushed
the
fix_odp_set_dirty
branch
from
7243b68 to
ab6ce0e
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In disaster recovery situation, if one of the servers gets unavailable for service, the new client will set the server as dirty and avoid to access to it again until it becomes available. But in odp mode, the client should not to set proxy's address as dirty, otherwise the proxy will never recover to valid.
Solution Description
In odp mode, do not set dirty to proxy's address. Disaster recovery policy should be implemented by the odp side.