Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an uppercase character again for the default in interactive questions #6289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Nov 7, 2024

Fix #6288

Please update master_changes.md file with your changes.

Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for this change. It fits with my ignored opinion in #5053 (comment) except for the <no character> part which requires some further changes which can be done separately if we want (i'll open a PR anyway, it's linked to a small bug i noticed), but i don't care as much about that as the standard unix [Y/n] question style

@hannesm
Copy link
Member Author

hannesm commented Nov 12, 2024

Thanks for the reftest fixes! Happy that there's an approval.

@rjbou
Copy link
Collaborator

rjbou commented Nov 13, 2024

Discussed on dev meeting: we all agree and welcome that change, thanks!

…ions

Fix ocaml#6288

Co-authored-by: Kate <kit-ty-kate@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: since using 2.2.1 (likely 2.2), the default answer to interactive questions is barely visible
3 participants