Post 2.3.0~alpha1 release bumps and fixes #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump done in 1e79693 Dune 2.6 makes the opam executables non-writeable so we have to chmod to strip the symbols
… the FreeBSD package manager This can happen when the current release is out-of-date (e.g. FreeBSD 13.2 vs 13.3)
This leaves more time for the release manager to execute 'net stop sshd && net start sshd' when needed, as sometimes Windows will refuse to have users ssh into the machine without a password
kit-ty-kate
force-pushed
the
post-2.3.0-alpha1
branch
from
94749c5
to
efdba21
Compare
dune 2.6 has a bug that prevents opam-core from being built
dra27
approved these changes
Sep 23, 2024
Comment on lines
+30
to
33
| chmod u+w _build/default/src/client/opamMain.exe && \ | ||
| strip opam ; \ | ||
| } >&2 && \ | ||
| cat opam |
There was a problem hiding this comment.
Wouldn't it be slightly better to copy it here? (or even potentially move this into Makefile - make opam-stripped or some such)? Along the lines of:
Suggested change
| chmod u+w _build/default/src/client/opamMain.exe && \ | |
| strip opam ; \ | |
| } >&2 && \ | |
| cat opam |
Suggested change
| chmod u+w _build/default/src/client/opamMain.exe && \ | |
| strip opam ; \ | |
| } >&2 && \ | |
| cat opam | |
| cp opam opam-stripped && \ | |
| chmod 775 opam-stripped && \ | |
| strip opam-stripped ; \ | |
| } >&2 && \ | |
| cat opam-stripped |
| @@ -124,6 +123,7 @@ host: $(OUTDIR)/opam-full-$(VERSION).tar.gz build/$(HOST).env | |||
| echo "$(call LINKING,$(HOST_OS))" >src/client/linking.sexp && \ | |||
| $(MAKE) opam; \ | |||
| ) | |||
| chmod u+w build/opam-full-$(VERSION)/_build/default/src/client/opamMain.exe | |||
There was a problem hiding this comment.
Similarly here: in fact, the duplication kinda increases the case for having $(MAKE) opam-stripped?
|
Just a minor data point that makes it a bit easier to package in operating systems is to use similar targets to GNU projects: in this case, it would be |
|
in our case the stripped binary is not installed but only copied to the root directory of the project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release process for 2.3.0~alpha1 was pretty eventful and a couple of fixes were required after the merge of #5381 which we missed.
This PR is also bumping master to 2.4.0~alpha1 as a new 2.3 branch was already created.
I'll create a similar PR for the 2.3 branch as wellBackported in #6205