Fix empty updates in dynamic init scripts #6198
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update of the form:
is not supposed to do anything to the environment (#5350). However, these updates were being written to the init scripts in opam-init (
variables.sh
, etc.). This PR fixes that, and consequently the problem with mingw-w64-shims reported in dra27/mingw-w64-shims#2 and #6053 (comment).Before this PR, for a switch with mingw-w64-shims and only the x86_64 installation, variables.sh has:
which is wrong, but after just:
Both before and after, the switch's
environment
file correctly has both entries: