Fix opam switch list-available pkg.version patttern
#6186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arozovyk
force-pushed
the
list_available_pkg.version_pat
branch
2 times, most recently
from
1538737
to
32b9d00
Compare
…oose if the filter is an OR or AND selector
rjbou
force-pushed
the
list_available_pkg.version_pat
branch
from
7c83981
to
4a5dc46
Compare
rjbou
approved these changes
Oct 30, 2024
kit-ty-kate
requested changes
Oct 30, 2024
There was a problem hiding this comment.
I'm not sure ands made sense in general in the first place. I think we should change the behaviour to use ors instead.
Otherwise there is no use to allow several parameters. e.g.
$ opam switch list-available ocaml-base-compiler ocaml-variants
# Listing available compilers from repositories: kit-ty-kate, default
# No matches found
If we switch to ors instead we can also simply remove the addition of the ?concat, which doesn't seem useful to me.
Ideally we should also have a test showing the behaviour of list-available with several parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #6152