Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable shallow clone by default except for opam repositories #6146

Merged

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Aug 8, 2024

Fixes #6145
Backported to the 2.2 branch by #6147

@reynir
Copy link
Contributor

reynir commented Aug 8, 2024

To clarify the opam repository pulls/clones are shallow due to this this constant value and not relying on the defaults of the optional argument:

let full_fetch = false in

@rjbou
Copy link
Collaborator

rjbou commented Aug 9, 2024

linked to #5888 (comment)

@rjbou rjbou self-requested a review August 9, 2024 17:42
@rjbou rjbou force-pushed the disable-shallow-clone-by-default branch from 300724b to f70c3cd Compare August 12, 2024 15:57
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!
I've added a test for fetching a package that highlights the behavior change on several cases. For repo fetching, as there is no change, it ensures that the repository is still fetched with no history.

@kit-ty-kate kit-ty-kate force-pushed the disable-shallow-clone-by-default branch from bc36596 to 41dddcf Compare August 12, 2024 19:40
@kit-ty-kate kit-ty-kate merged commit 2ee2c1b into ocaml:master Aug 12, 2024
29 checks passed
@kit-ty-kate kit-ty-kate deleted the disable-shallow-clone-by-default branch August 12, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git --depth 1 breaks orb/dune
3 participants