Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression: deps-only setting direct dependencies as root packages by default #6125

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Fix regression: deps-only setting direct dependencies as root packages by default #6125

merged 2 commits into from
Jul 30, 2024

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Jul 30, 2024

It was added in #4564, accidentally removed in #4975.

Backported in 2.2 in #6126

@rjbou rjbou added this to the 2.3.0~alpha milestone Jul 30, 2024
@rjbou rjbou requested review from AltGr and kit-ty-kate July 30, 2024 14:05
@rjbou rjbou marked this pull request as ready for review July 30, 2024 14:05
@rjbou rjbou mentioned this pull request Jul 30, 2024
Merged
kit-ty-kate
kit-ty-kate approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

src/client/opamClient.ml Outdated Show resolved Hide resolved
@rjbou @kit-ty-kate
install: fix regression of --deps-only that sets direct dependencies …
5a324c1 
…as root packages by default

Introduced in ffc076b
Accidentally removed in 9aa2290
@kit-ty-kate
Copy link
Member

LGTM'd by @AltGr

Thanks!

@kit-ty-kate kit-ty-kate merged commit 0ea9e2d into ocaml:master Jul 30, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

@AltGr AltGr Awaiting requested review from AltGr

Assignees
No one assigned
Labels
KIND: BUG
Projects
None yet
Milestone
2.3.0~alpha1
Development

Successfully merging this pull request may close these issues.
2 participants
@rjbou @kit-ty-kate