Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin hashes cache: move under opam root #6103

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Jul 17, 2024

opam admin add-hashes creates a cache that is actually stored under ~/.cache/hash-cache. Move it in <opamroot>/download-cache/hash-cache.

Previous one was ~/.cache/opam-hash-cache, which affects tests. Even if
there is no opam root defined, it will create one and add it under that
opam root. There is then less user home modification.
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've renamed the hash_tables function into create_hash_tables otherwise it's way too confusing between the hash_tables function and the hash_tables value.

@kit-ty-kate kit-ty-kate added this to the 2.3.0~alpha milestone Jul 24, 2024
@rjbou rjbou merged commit 5541b3e into ocaml:master Jul 24, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants