Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package name encoding in conflict message #6055

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Package name encoding in conflict message #6055

merged 2 commits into from
Jul 2, 2024

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Jun 25, 2024

fix #6030

dra27
dra27 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - given that it's been wrong for nearly 3 years, I guess we can leave this as a post 2.2.0 fix?

master_changes.md Outdated Show resolved Hide resolved
@rjbou
Copy link
Collaborator Author

rjbou commented Jun 26, 2024

yes, it's not meant to be in 2.2 final

@rjbou rjbou added this to the 2.3 milestone Jun 27, 2024
@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit f974540 into ocaml:master Jul 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dra27 dra27 dra27 approved these changes

Assignees
No one assigned
Labels
AREA: UI
Projects
None yet
Milestone
2.3.0~alpha1
Development

Successfully merging this pull request may close these issues.

spurious percent-encoding in output
3 participants
@rjbou @kit-ty-kate @dra27