Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.3.0~alpha~dev #6045

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Jun 21, 2024

  • update tests
  • Bump cli version/add cli 2.3

@rjbou rjbou added this to the 2.2.0 milestone Jun 21, 2024
@dra27
Copy link
Member

dra27 commented Jun 21, 2024

Doesn't master now become 2.3.0~dev?

@rjbou rjbou changed the title Bump version to 2.2.0~dev Bump version to 2.3.0~alpha~dev Jun 24, 2024
@rjbou rjbou modified the milestones: 2.2.0, 2.3 Jun 24, 2024
@@ -1,6 +1,8 @@
11ea1cb
### OPAMYES=1 OPAMSTRICT=0
### OPAMVAR_arch=x86_64 OPAMVAR_os=linux OPAMVAR_os_family=arch OPAMVAR_os_distribution=archarm
### # We need to set this version to keep the test as is
### OPAMVAR_opam_version=2.2.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we should update the test (and possibly alter it?) or freeze it like that...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it looks a bit weird, but I think it's OK - the only thing which might be worth double-checking is whether the bounds actually matter i.e. if something actually needs fixing in opam-repository? But this could be tracked in a follow-up issue/note, rather than blocking the version bump.

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@@ -1,6 +1,8 @@
11ea1cb
### OPAMYES=1 OPAMSTRICT=0
### OPAMVAR_arch=x86_64 OPAMVAR_os=linux OPAMVAR_os_family=arch OPAMVAR_os_distribution=archarm
### # We need to set this version to keep the test as is
### OPAMVAR_opam_version=2.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it looks a bit weird, but I think it's OK - the only thing which might be worth double-checking is whether the bounds actually matter i.e. if something actually needs fixing in opam-repository? But this could be tracked in a follow-up issue/note, rather than blocking the version bump.

@rjbou
Copy link
Collaborator Author

rjbou commented Jul 1, 2024

Discussed in meeting: seems that setting the opam-version variable is the good fix, to keep tests as is.

@kit-ty-kate kit-ty-kate merged commit cfa7568 into ocaml:master Jul 1, 2024
57 checks passed
@kit-ty-kate
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants