-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 2.3.0~alpha~dev #6045
Conversation
rjbou
commented
Jun 21, 2024
•
edited
Loading
edited
- update tests
- Bump cli version/add cli 2.3
Doesn't master now become 2.3.0~dev? |
@@ -1,6 +1,8 @@ | |||
11ea1cb | |||
### OPAMYES=1 OPAMSTRICT=0 | |||
### OPAMVAR_arch=x86_64 OPAMVAR_os=linux OPAMVAR_os_family=arch OPAMVAR_os_distribution=archarm | |||
### # We need to set this version to keep the test as is | |||
### OPAMVAR_opam_version=2.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we should update the test (and possibly alter it?) or freeze it like that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it looks a bit weird, but I think it's OK - the only thing which might be worth double-checking is whether the bounds actually matter i.e. if something actually needs fixing in opam-repository? But this could be tracked in a follow-up issue/note, rather than blocking the version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@@ -1,6 +1,8 @@ | |||
11ea1cb | |||
### OPAMYES=1 OPAMSTRICT=0 | |||
### OPAMVAR_arch=x86_64 OPAMVAR_os=linux OPAMVAR_os_family=arch OPAMVAR_os_distribution=archarm | |||
### # We need to set this version to keep the test as is | |||
### OPAMVAR_opam_version=2.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it looks a bit weird, but I think it's OK - the only thing which might be worth double-checking is whether the bounds actually matter i.e. if something actually needs fixing in opam-repository? But this could be tracked in a follow-up issue/note, rather than blocking the version bump.
Discussed in meeting: seems that setting the |
Thanks! |