Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opam init -yn asking questions on Windows #6033

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Jun 18, 2024

Fixes #6013. Mostly this was simply that ~yes parameters were not provided when they should have been. The slightly more subtle fix is if MSYS2 is initialised which is requires --confirm-level unsafe-yes but lacked a ~yes. In this case, the action for -y is simply is to ignore the change.

`opam init -y` wasn't working.
Initialising MSYS2 requires unsafe-yes, but the default for -y (to
ignore) was missing.
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dra27 dra27 merged commit 503a636 into ocaml:master Jun 19, 2024
28 of 29 checks passed
@dra27 dra27 deleted the opam-init-yn branch June 19, 2024 19:18
@rjbou
Copy link
Collaborator

rjbou commented Jun 19, 2024

Red CI is from benchmark test broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opam init -yn still asks for cygwin and git related questions on Windows if ran from a terminal
2 participants