Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error message when a directory is not available while fetching using rsync #6027

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Jun 17, 2024

Extracted from #6015
Fixes #5632

@kit-ty-kate kit-ty-kate mentioned this pull request Jun 17, 2024
@rjbou rjbou self-requested a review July 9, 2024 08:59
src/repository/opamLocal.ml Outdated Show resolved Hide resolved
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I prefer this to #5689)

Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kit-ty-kate kit-ty-kate merged commit a182327 into ocaml:master Sep 16, 2024
29 checks passed
@kit-ty-kate kit-ty-kate deleted the improved-error-msg-rsync branch September 16, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opam 2.1.4 fails to add a local repository if opam repo add is invoked from a "grandparent directory"
3 participants