Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the lower-bound constraint on ocaml-re #6016

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Jun 12, 2024

Re.Group.get_opt was added in re 1.10.0

Noticed in ocaml/opam-repository#26053

#=== ERROR while compiling opam-client.2.2.0~beta3 ============================#
# context              2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.4.08.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.08/.opam-switch/build/opam-client.2.2.0~beta3
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p opam-client -j 255
# exit-code            1
# env-file             ~/.opam/log/opam-client-7-ac1441.env
# output-file          ~/.opam/log/opam-client-7-ac1441.out
### output ###
#       ocamlc src/client/.opam_client.objs/byte/opamClient.{cmo,cmt} (exit 2)
# (cd _build/default && /home/opam/.opam/4.08/bin/ocamlc.opt -w -40 -w +a-4-40-42-44-48 -safe-string -g -bin-annot -I src/client/.opam_client.objs/byte -I /home/opam/.opam/4.08/lib/0install-solver -I /home/opam/.opam/4.08/lib/base64 -I /home/opam/.opam/4.08/lib/bytes -I /home/opam/.opam/4.08/lib/bz2 -I /home/opam/.opam/4.08/lib/cmdliner -I /home/opam/.opam/4.08/lib/cudf -I /home/opam/.opam/4.08/lib/dose3/algo -I /home/opam/.opam/4.08/lib/dose3/common -I /home/opam/.opam/4.08/lib/extlib -I /home/opam/.opam/4.08/lib/fmt -I /home/opam/.opam/4.08/lib/jsonm -I /home/opam/.opam/4.08/lib/mccs -I /home/opam/.opam/4.08/lib/mccs/glpk/internal -I /home/opam/.opam/4.08/lib/ocamlgraph -I /home/opam/.opam/4.08/lib/opam-0install-cudf -I /home/opam/.opam/4.08/lib/opam-core -I /home/opam/.opam/4.08/lib/opam-file-format -I /home/opam/.opam/4.08/lib/opam-format -I /home/opam/.opam/4.08/lib/opam-repository -I /home/opam/.opam/4.08/lib/opam-solver -I /home/opam/.opam/4.08/lib/opam-state -I /home/opam/.opam/4.08/lib/re -I /home/opam/.opam/4.08/lib/re/pcre -I /home/opam/.opam/4.08/lib/seq -I /home/opam/.opam/4.08/lib/sha -I /home/opam/.opam/4.08/lib/spdx_licenses -I /home/opam/.opam/4.08/lib/stdlib-shims -I /home/opam/.opam/4.08/lib/swhid_core -I /home/opam/.opam/4.08/lib/uchar -I /home/opam/.opam/4.08/lib/uutf -I /home/opam/.opam/4.08/lib/zip -intf-suffix .ml -no-alias-deps -o src/client/.opam_client.objs/byte/opamClient.cmo -c -impl src/client/opamClient.ml)
# File "src/client/opamClient.ml", line 980, characters 60-76:
# 980 |             Stdlib.Option.bind (Re.exec_opt re s) (Fun.flip Re.Group.get_opt 1)
#                                                                   ^^^^^^^^^^^^^^^^
# Error: Unbound value Re.Group.get_opt

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kit-ty-kate kit-ty-kate added this to the 2.2.0~rc1 milestone Jun 17, 2024
Re.Group.get_opt was added in re 1.10.0
@kit-ty-kate
Copy link
Member Author

Benchmark failed because of ocaml/ocaml#13237

@kit-ty-kate kit-ty-kate merged commit 76258c0 into ocaml:master Jun 18, 2024
28 of 29 checks passed
@kit-ty-kate kit-ty-kate deleted the lower-bound-re branch June 18, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants