Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display lock hold/release messages on stderr instead of stdout #5999

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Display lock hold/release messages on stderr instead of stdout #5999

merged 1 commit into from
Jun 6, 2024

Conversation

kit-ty-kate
Copy link
Member

Fixes #5990

dra27
dra27 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changes entry, but all LGTM!

@kit-ty-kate kit-ty-kate added this to the 2.2.0~beta3 milestone Jun 6, 2024
@kit-ty-kate kit-ty-kate mentioned this pull request Jun 6, 2024
Closed
@rjbou rjbou self-requested a review June 6, 2024 09:33
rjbou
rjbou approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

master_changes.md Outdated Show resolved Hide resolved
master_changes.md Outdated Show resolved Hide resolved
@kit-ty-kate kit-ty-kate merged commit 5c582e1 into ocaml:master Jun 6, 2024
29 checks passed
@kit-ty-kate kit-ty-kate deleted the lock-stderr branch June 6, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbou rjbou rjbou approved these changes

@dra27 dra27 dra27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0~beta3
Development

Successfully merging this pull request may close these issues.

lock hold/release messages as part of another command should be printed on stderr
3 participants
@kit-ty-kate @dra27 @rjbou