Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wind CI forwards to the Windows compilers #5998

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Wind CI forwards to the Windows compilers #5998

merged 1 commit into from
Jun 6, 2024

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Jun 6, 2024

No description provided.

@dra27 dra27 mentioned this pull request Jun 6, 2024
Merged
@rjbou rjbou added this to the 2.2.0~beta3 milestone Jun 6, 2024
rjbou
rjbou approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rjbou
Copy link
Collaborator

rjbou commented Jun 6, 2024

Is it needed to wait for #6000 CI to validate it ?

@dra27
Copy link
Member Author

dra27 commented Jun 6, 2024

Actually, I think it's the other way around - if the failure seen on my fork is real, then #6000 is at fault. Let's merge this and I'll rebase #6000 on to it.

@dra27 dra27 merged commit 1ff0770 into ocaml:master Jun 6, 2024
39 checks passed
@dra27 dra27 deleted the wind-ci branch June 6, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbou rjbou rjbou approved these changes

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0~beta3
Development

Successfully merging this pull request may close these issues.
3 participants
@dra27 @rjbou @kit-ty-kate