API: Allow explicit installation of system packages #5994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual menu and depext handling part of OpamSolution.install_depexts is now in OpamSolution.install_sys_packages, providing a lower-level way of requesting the OS package manager to install some packages.
kit-ty-kate
approved these changes
Jun 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring in
OpamSolutionso that the depext menu can be displayed either with a list of opam packages (asOpamSolution.install_depextspresently does, or slightly lower-level where the set of system packages to install is already calculated by the caller (the newOpamSolution.install_sys_packages).Additionally, the existing
OpamSolution.print_depext_msgis exposed (ultimately to allow it be used byOpamClient).