Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move last-env OPAM_LAST_ENV files outside the switch #5962

Merged
merged 1 commit into from
May 24, 2024
Merged

Move last-env OPAM_LAST_ENV files outside the switch #5962

merged 1 commit into from
May 24, 2024

Conversation

moyodiallo
Copy link
Contributor

Fixes #5823 by storing the last-env OPAM_LAST_ENV files in the directory ~/.opam/.last-env instead of in the switch as the solution described in the issue.

@moyodiallo
Copy link
Contributor Author

moyodiallo commented May 17, 2024 •
edited
Loading

@dra27 Do we need more test here beside your tests from #5417 ?

@kit-ty-kate kit-ty-kate added this to the 2.2.0~beta3 milestone May 17, 2024
kit-ty-kate
kit-ty-kate approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one question, I think this looks pretty good.

src/client/opamCommands.ml Outdated Show resolved Hide resolved
@moyodiallo moyodiallo marked this pull request as ready for review May 17, 2024 13:16
@kit-ty-kate kit-ty-kate requested a review from rjbou May 21, 2024 22:30
@rjbou rjbou mentioned this pull request May 24, 2024
Open
@moyodiallo @rjbou
Move last-env OPAM_LAST_ENV files outside the switch.
4d5033a 
The last-env files are now stored in `~/.opam/.last-env` dir.
rjbou
rjbou approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I've added an entry in API changes, otherwise, LGTM!

@rjbou rjbou merged commit ff1c97b into ocaml:master May 24, 2024
29 checks passed
@moyodiallo moyodiallo deleted the last-env branch May 24, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dra27 dra27 dra27 left review comments

@rjbou rjbou rjbou approved these changes

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

Assignees
No one assigned
Labels
AREA: ENGINE
Projects
None yet
Milestone
2.2.0~beta3
Development

Successfully merging this pull request may close these issues.

last-env files should be stored outside the switch
4 participants
@moyodiallo @kit-ty-kate @dra27 @rjbou