Stop populating opam file with extra-files #5564
Conversation
rjbou
added
the
PR: QUEUED
rjbou
force-pushed
the
undeclared-extra-files
branch
from
1f093cf
to
c668919
Compare
|
fix #5013 |
rjbou
force-pushed
the
undeclared-extra-files
branch
from
c668919
to
63b9546
Compare
|
looks good to me, but I'd as well be happy if you point me to the rebased PR once #5561 is merged :) |
rjbou
force-pushed
the
undeclared-extra-files
branch
from
aaa554c
to
a3bdcfc
Compare
rjbou
force-pushed
the
undeclared-extra-files
branch
from
f389e77
to
70d1cf7
Compare
rjbou
changed the title
rjbou
changed the title
rjbou
changed the title
master_changes.md
Outdated
|
|
||
| ## Repository | ||
| * Mitigate curl/curl#13845 by falling back from --write-out to --fail if exit code 43 is returned by curl [#6168 @dra27 - fix #6120] | ||
| * When loading a repository, no more automatically populate `extra-files:` field with found files in `files/` [#5564 @rjbou] |
There was a problem hiding this comment.
| * When loading a repository, no more automatically populate `extra-files:` field with found files in `files/` [#5564 @rjbou] | |
| * When loading a repository, stop automatically populate `extra-files:` field with found files in `files/` [#5564 @rjbou] |
rjbou
force-pushed
the
undeclared-extra-files
branch
from
70d1cf7
to
e82bad9
Compare
|
rebased |
rjbou
force-pushed
the
undeclared-extra-files
branch
from
e82bad9
to
cdc869e
Compare
master_changes.md
Outdated
| @@ -249,6 +251,8 @@ users) | |||
| ## opam-state | |||
| * `OpamStateConfig.opamroot_with_provenance`: restore previous behaviour to `OpamStateConfig.opamroot` for compatibility with third party code [#6047 @dra27] | |||
| * `OpamSwitchState.{,reverse_}dependencies`: make `unavailable` a non-optional argument to enforce speedups when availability information is not needed [#5317 @kit-ty-kate] | |||
| * `OpamFilteTools.add_aux_files`: ignore non registered extra-files [#5564 @@rjbou] | |||
There was a problem hiding this comment.
the ""new"" optional argument should be added to the changelog
rjbou
force-pushed
the
undeclared-extra-files
branch
from
cdc869e
to
36c63b4
Compare
kit-ty-kate
removed
the
PR: QUEUED
rjbou
force-pushed
the
undeclared-extra-files
branch
from
abe29d8
to
04cbf27
Compare
|
Updated opam-rt, should be good by now. The corresponding PR in opam-rt (ocaml-opam/opam-rt#78) should be merged in the same time. |
rjbou
force-pushed
the
undeclared-extra-files
branch
from
04cbf27
to
04d3023
Compare
|
Tests fixed! |
kit-ty-kate
force-pushed
the
undeclared-extra-files
branch
from
04d3023
to
f976365
Compare
|
updated |
kit-ty-kate
force-pushed
the
undeclared-extra-files
branch
from
f976365
to
78fb5d4
Compare
There was a problem hiding this comment.
Some suggestions for the re-wording in the manual - I find it confusing that we refer to the field as being mandatory, when what we're really meaning is that referring to each file in the field is mandatory.
I'm uneasy that we change this behaviour with no backwards compatibility - i.e. there are (CI) workflows which work today with opam 2.2 which unconditionally stop working with opam 2.3. That said, from a security standpoint it's obviously much better and the fix required for 2.3 compatibility is obviously completely compatible with older versions. So let's just ensure that the announcements for 2.3 make that crystal clear!
It was at the origin a temporary thing, to transition. But it stayed so long that it became kind of as a feature.
Yes, plus there is the command |
…:' automatically from 'files/' directory
kit-ty-kate
force-pushed
the
undeclared-extra-files
branch
from
125868c
to
9a221be
Compare
|
Thanks a lot! |
Current behaviour is at lint stage, if an extra-files is found in
filesdirectory, but not in the opam file, it is added in the opam file automatically.This behaviour is removed, all extra-files need to be declared in opam file.
/cc @hannesm @reynir