test: add sources directory cleaning test #5474
Conversation
rjbou
force-pushed
the
clean-source
branch
2 times, most recently
from
9213fb6
to
672d5d7
Compare
rjbou
added
PR: WAITING FOR REVIEW
and removed
PR: WIP
There was a problem hiding this comment.
Apparently for me it's much easier to suggest to other people to add comments to their tests, than it is to remember to put comments in my tests in the first place.
I think we should definitely tag the cases which are errors (I think at least the remaining waste.1 after opam install is an error??) and we probably can't have too many ls calls in this test!
| -> installed waste.1 | ||
| Done. | ||
| ### ls OPAM/clean/.opam-switch/sources/ | ||
| waste.1 |
There was a problem hiding this comment.
This one's part of the original bug, right? After opam install, there's no need for it to be there?
There was a problem hiding this comment.
It's not a bug, it's a feature xD But yes, it definitively show the current behaviour to store all sources files in sources
| -> removed waste.1 | ||
| -> installed waste.1 | ||
| Done. | ||
| ### ls OPAM/clean/.opam-switch/sources |
There was a problem hiding this comment.
Correct the difference here is that opam install waste has left the sources directory populated, but opam reinstall waste has removed it?
kit-ty-kate
force-pushed
the
clean-source
branch
from
a04082a
to
6dc7b3e
Compare
kit-ty-kate
force-pushed
the
clean-source
branch
from
6dc7b3e
to
93d11e9
Compare
|
Thanks! |
related #5448