Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reftests: updates on init test #5327

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Oct 25, 2022

Update it to be no repo + add erroneous case where invariant got removed from install actions

@dra27
Copy link
Member

dra27 commented May 9, 2024

This is likely to be a pain, so feel free to object! I like the switch to N0REP0 because it's faster, but might it be worth using the same package names and versions? i.e. instead of comp.2 call it ocaml.4.02.3 and comp.3 be ocaml.4.05.0, etc.?

I'm being slow, but I don't understand the second commit - is the point that we're ensuring that without the conflict-class that we do incorrectly install syscomp.2, or is it that there a bug which needs fixing?

@kit-ty-kate kit-ty-kate removed their request for review May 9, 2024 13:24
@rjbou
Copy link
Collaborator Author

rjbou commented May 14, 2024

I'm being slow, but I don't understand the second commit - is the point that we're ensuring that without the conflict-class that we do incorrectly install syscomp.2, or is it that there a bug which needs fixing?

My mistake, it was me wrongly defining the packages. I wanted to highlight a wrong behaviour of installing a package that doesn't comply invariant, but comp dependencies (post especially) wasn't well defined.

@rjbou
Copy link
Collaborator Author

rjbou commented May 14, 2024

Updated with ocaml-* package names

@kit-ty-kate
Copy link
Member

Thanks! Failure in ocaml-benchmarks comes from a lack of disk space

@kit-ty-kate kit-ty-kate merged commit a4d9695 into ocaml:master Jul 9, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants