Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failure to fetch git submodules are not errors #6131

Closed
kit-ty-kate opened this issue Jul 31, 2024 · 2 comments · Fixed by #6132
Closed

failure to fetch git submodules are not errors #6131

kit-ty-kate opened this issue Jul 31, 2024 · 2 comments · Fixed by #6132

Comments

@kit-ty-kate
Copy link
Member

c030dcb (in opam 2.0) added support for git submodules when pulling a source repository.
However currently failures while fetching the submodules are not errors but only displays a warning. I think this should be an error instead, as not stopping early can change the behaviour of building a such a package drastically.

@hhugo
Copy link
Contributor

hhugo commented Jul 31, 2024

related to #6021

@kit-ty-kate
Copy link
Member Author

good point, although in your case Windows' MAX_PATH is the real culprit but indeed failing early would show a better error message for sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants