Skip to content

Package echo.0.0.5 #27974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025
Merged

Package echo.0.0.5 #27974

merged 5 commits into from
Jul 15, 2025

Conversation

deakodev
Copy link
Contributor

@deakodev deakodev commented Jun 2, 2025

echo.0.0.5 - fix log flushing and easy echo.h install include

A minimal interop OCaml + C logging solution
Echo is a lightweight logging library for OCaml with C lib bindings, allowing both OCaml and C code to emit structured log messages through a unified logging interface.



🐫 Pull-request generated by opam-publish v2.5.1

@ivnhk
Copy link

ivnhk commented Jun 2, 2025

Hey @deakodev

Thanks for the new patch :)

I don't see any issues with the CI.

riscv64-ocaml-5.3 and iscv64-ocaml-4.14 archs are still waiting for workers. Overall, I think we can merge this.

@ivnhk ivnhk mentioned this pull request Jun 2, 2025
bug-reports: "https://github.com/deakodev/echo/issues"
depends: [
"dune" {>= "3.18"}
"ocaml" {>= "4.14" & < "5.2"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the upper bound necessary?

@ivnhk
Copy link

ivnhk commented Jun 10, 2025

Hey @deakodev

I see the last remaining error:

opam-repo-ci detected dependencies failing:  conf-pkg-config.1.0 dune.3.18.0 ocamlbuild.0.14.3 ocamlfind.1.9.6

yet only for 5.4~alpha1.

I'm not sure it's critical to support this version right now.

@ivnhk ivnhk self-requested a review June 10, 2025 18:19
@shonfeder
Copy link
Contributor

This is [a lower bounds](
See https://github.com/ocaml/opam-repository/wiki/How-to-deal-with-CI#dependency-lower-bounds) failure:

lower-bounds (failed: conf-pkg-config.1.0 dune.3.18.0 ocamlbuild.0.14.3 ocamlfind.1.9.6 failed to build)

This is generally important to address, otherwise it can lead to glimpses of dependency hell for users :D

@shonfeder
Copy link
Contributor

Sorry for the delay here! The lower bounds error on OCaml 5.4 is not relevant, since that is a preview version. This fell between the cracks and I apologize for that.

Thank you for publishing the update!

@shonfeder shonfeder merged commit 224060a into ocaml:master Jul 15, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants