Skip to content

Add clock emoji before 'since' tag #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Add clock emoji before 'since' tag #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a23588f
Add clock emoji before 'since' tag
yawaramin Mar 7, 2024
a21b7ff
Add changelog entry
yawaramin Mar 7, 2024
12fffdc
Add alt text so screen readers will ignore emojis
yawaramin Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
(@panglesd, #976)
- Separate compilation of interface and implementation files, using a new
`compile-src` command (@panglesd, #1067).
- Add clock emoji before `@since` tag (@yawaramin, #1089)

### Changed

Expand Down
8 changes: 7 additions & 1 deletion src/html_support_files/odoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,13 @@ td.def-doc *:first-child {
/* Alert emoji */

.alert::before, .deprecated::before {
content: '⚠️ ';
content: '⚠️ ' / '';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just informational, the / '' here is to set the alt text to an empty string which tells the screen reader to not read out the emoji because it is strictly decorative and redundant for spoken text.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting, thanks!

}

/* Since emoji */

.since::before {
content: '🕚 ' / '';
}

/* Lists of modules */
Expand Down