Stack overflow on core_kernel__List0.cmt

[dbuenzli]

Steps to reproduce:

opam install odig odoc core_kernel.v0.13.0
odig odoc
[...]
[FAILED][spawn:2815]
 Illegal exit status: exited [2] expected: 0
 cmd: ['/Users/dbuenzli/.opam/4.09.0/bin/odoc' 'compile' '--pkg' 'core_kernel' '-o' '/Users/dbuenzli/.opam/4.09.0/var/cache/odig/odoc/core_kernel/core_kernel__List0.odoc' 
[...] 
 stdo-ui: odoc: internal error, uncaught exception:
      Stack overflow
      Raised at file "hashtbl.ml", line 506, characters 17-32
      Called from file "src/xref/expand.ml", line 692, characters 6-38
[...]

With opam pin odoc --dev I get a different backtrace:

 stdo-ui: odoc: internal error, uncaught exception:
      Stack overflow
      Raised by primitive operation at file "src/odoc/compile.ml", line 43, characters 4-55
      Called from file "cmdliner_term.ml", line 25, characters 19-24
      Called from file "cmdliner_term.ml", line 23, characters 12-19
      Called from file "cmdliner.ml", line 117, characters 32-39

Maybe releated to #388

[jonludlam]

I don't believe this is related to #388

[jonludlam]

Interesting - the failure disappears when you remove '-I' '~/.opam/4.09.0/var/cache/odig/odoc/base/' from the invocation of odoc.

[jonludlam]

Looking into this again now. Building the documentation with dune (via a bit of vendoring and manual odoc compilation of stdlib and others) is succeeding while doing it with odig is failing, so something odd is going on. I'll update when I know more.

[jonludlam]

A slightly more complete vendoring demonstrated the problem again, fortunately.

[sarna]

Any updates on this? It's still not possible to build docs for core_kernel, which is a pretty important module.

[jonludlam]

I'm currently working on a reimplementation of the model which doesn't exhibit this issue. It's not quite ready to go but if you want to see the current state you can try this branch: https://github.com/jonludlam/odoc/tree/next-rebased

[sarna]

Wow, that's a lot of changes!

Glad to see it's being dealt with. I really appreciate the hard work, thank you 🙏

[jonludlam]

Fixed with the new model

[sarna]

Thank you for putting in the work!