Don't make finaliser updates dependent on work being available.

Author: NickBarnes

runtime/major_gc.c

@@ -1985,8 +1985,15 @@ static void major_collection_slice(intnat howmuch,
 
   if (mode != Slice_opportunistic && caml_marking_started()) {
     /* Finalisers */
+
+    /* TODO: various improvement work here:
+     * - updating finalisers should be made incremental;
+     * - we should measure and account for the work of it against our work meters.
+     * - but until it is made incremental we can't gate it on having work available
+     *   because we have to do it (and therefore advance the phase) even in domains
+     *   which don't allocate. */
+
     if (caml_gc_phase == Phase_mark_final &&
-        get_major_slice_work(mode) > 0 &&
         caml_final_update_first(domain_state)) {
       /* This domain has updated finalise first values */
       (void)caml_atomic_counter_decr(&num_domains_to_final_update_first);
@@ -1995,8 +2002,9 @@ static void major_collection_slice(intnat howmuch,
         goto mark_again;
     }
 
+    /* TODO finaliser improvement work as listed above. */
+
     if (caml_gc_phase == Phase_sweep_ephe &&
-        get_major_slice_work(mode) > 0 &&
         caml_final_update_last(domain_state)) {
       /* This domain has updated finalise last values */
       (void)caml_atomic_counter_decr(&num_domains_to_final_update_last);
@@ -2092,6 +2100,9 @@ static void major_collection_slice(intnat howmuch,
     }
 
     /* Complete GC phase */
+
+    /* TODO: move this outside the containing if so that it's possible
+     * in opportunistic slices? */
     if (is_complete_phase_sweep_and_mark_main() ||
         is_complete_phase_mark_final ()) {
       CAMLassert (caml_gc_phase != Phase_sweep_ephe);