OCaml 5.4 upgrade #1938
Open
OCaml 5.4 upgrade #1938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kit-ty-kate looks like it requires pulling more changes than bumping the magic numbers, I will not have the time to do that until Monday unfortunately. @xvw (@pitag-ha, @PizieDust) do you have the time/ want to have a go at this at this ? (apply all patches in branch 5.4 since commit 3e872717d3691511f4d409f5173455fde1e63ff2) If not we will do it together on Monday :-) |
They contain more information and are overall more convenient than inline diffs.
voodoos
changed the title
kit-ty-kate
approved these changes
May 26, 2025
That's great to hear, thanks for the feedback! Do you think you could cut a preview release with this branch and the corresponding lsp one ? (https://github.com/voodoos/ocaml-lsp.git#504-compat) |
|
now that ocaml 5.4.0~alpha1 has been released, yes |
|
Done in ocaml/opam-repository#27928 and ocaml/opam-repository#27927 using these commands:
|
voodoos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1937